Re-implement request body previews on Android#55456
Closed
huntie wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Summary: Follows #55706. Updates the signature of `onCreateRequest`, and removes legacy `onCreateRequest` and `onResponseReceived` overloads — effectively de-OkHttp-ing this internal API. Changelog: [Internal] Differential Revision: D94510863
huntie
force-pushed
the
export-D89381124
branch
2 times, most recently
from
330c229 to
6959187
Compare
Summary: Pull Request resolved: #55456 **Context** Follow-up to D89373824, which addressed a runtime Android crash with `FormData` uploads (#54881) but introduced a "[Preview unavailable]" fallback for the `ProgressRequestBody` case. **This diff** Reintroduce request body previews under this case. Protects agains the original crash by: - Checking `body.isOneShot()` to prevent disallowed double-reads of stream bodies. - [Pre-existing] Preserves `BuildConfig.DEBUG` guard added in D89377163. Changelog: [Android][Added] - React Native DevTools: Restore request payload previews on Android Differential Revision: D89381124
huntie
force-pushed
the
export-D89381124
branch
from
6959187 to
91ea6c1
Compare
|
This pull request has been merged in cc44e96. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
Summary: So the formData Upload in fetch is broken on 0.85 on main. I tracked down this PR #55456 Also reported here #56404 RCA:- ``` body.isOneShot() body.writeTo(buffer) // This is draining inner file InputStreams ``` Fix is to walk to each children of multipart and check for Oneshot ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID][FIXED] - FormData uploads broken in debug builds Pull Request resolved: #56406 Test Plan: Tested on RN tester <img width="416" height="600" alt="image" src="https://github.com/user-attachments/assets/20cae662-e2ba-4fc7-9f8d-d8e365eb95b2" /> Reviewed By: fabriziocucci, huntie Differential Revision: D100258994 Pulled By: alanleedev fbshipit-source-id: aeda47d45db2152027598c949f0e602a586c4cb3
react-native-bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
Summary: So the formData Upload in fetch is broken on 0.85 on main. I tracked down this PR #55456 Also reported here #56404 RCA:- ``` body.isOneShot() body.writeTo(buffer) // This is draining inner file InputStreams ``` Fix is to walk to each children of multipart and check for Oneshot ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID][FIXED] - FormData uploads broken in debug builds Pull Request resolved: #56406 Test Plan: Tested on RN tester <img width="416" height="600" alt="image" src="https://github.com/user-attachments/assets/20cae662-e2ba-4fc7-9f8d-d8e365eb95b2" /> Reviewed By: fabriziocucci, huntie Differential Revision: D100258994 Pulled By: alanleedev fbshipit-source-id: aeda47d45db2152027598c949f0e602a586c4cb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Follow-up to #54917, which addressed a runtime Android crash with
FormDatauploads (#54881) but introduced a "[Preview unavailable]" fallback for theProgressRequestBodycase.This diff
Reintroduce request body previews under this case.
Protects agains the original crash by:
body.isOneShot()to prevent disallowed double-reads of stream bodies.BuildConfig.DEBUGguard added in D89377163.Changelog:
[Android][Added] - React Native DevTools: Restore request payload previews on Android
Differential Revision: D89381124